Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: handle ENUM in builtin function Values() #9225

Merged
merged 7 commits into from
Feb 12, 2019
Merged

expression: handle ENUM in builtin function Values() #9225

merged 7 commits into from
Feb 12, 2019

Conversation

zz-jason
Copy link
Member

Signed-off-by: Jian Zhang [email protected]

What problem does this PR solve?

fix #9165

What is changed and how it works?

handle ENUM in builtinValuesStringSig

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

@codecov-io
Copy link

codecov-io commented Jan 30, 2019 •
edited
Loading

Codecov Report

Merging #9225 into master will decrease coverage by <.01%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9225      +/-   ##
==========================================
- Coverage   67.26%   67.25%   -0.01%     
==========================================
  Files         371      371              
  Lines       77223    77222       -1     
==========================================
- Hits        51943    51935       -8     
- Misses      20642    20647       +5     
- Partials     4638     4640       +2
Impacted Files Coverage Δ
expression/column.go 77.4% <ø> (+1.57%) ⬆️
expression/builtin_other.go 65.45% <77.77%> (+0.09%) ⬆️
store/tikv/scan.go 73.94% <0%> (-3.37%) ⬇️
ddl/delete_range.go 77.77% <0%> (-1.59%) ⬇️
store/tikv/lock_resolver.go 41.7% <0%> (-0.95%) ⬇️
executor/index_lookup_join.go 77.28% <0%> (-0.64%) ⬇️
executor/executor.go 67.03% <0%> (-0.28%) ⬇️
executor/join.go 78.38% <0%> (+0.52%) ⬆️
expression/schema.go 94.53% <0%> (+0.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 935a440...6152000. Read the comment docs.

eurekaka
eurekaka reviewed Jan 30, 2019
View reviewed changes
expression/builtin_other.go Show resolved Hide resolved
expression/builtin_other.go Outdated Show resolved Hide resolved
expression/builtin_other.go Outdated Show resolved Hide resolved
@zz-jason
Copy link
Member Author

/run-all-tests

eurekaka
eurekaka reviewed Feb 12, 2019
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 12, 2019
alivxxx
alivxxx approved these changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 12, 2019
@zz-jason
Copy link
Member Author

/run-all-tests

@zz-jason
Copy link
Member Author

/run-unit-test

@zz-jason zz-jason merged commit 84750e8 into pingcap:master Feb 12, 2019
@zz-jason zz-jason deleted the bugfix/values-enum branch February 12, 2019 03:49
zz-jason added a commit to zz-jason/tidb that referenced this pull request Feb 12, 2019
@zz-jason
expression: handle ENUM in builtin function Values() (pingcap#9225)
d07cee1
@zz-jason zz-jason mentioned this pull request Feb 12, 2019
Merged
zz-jason added a commit to zz-jason/tidb that referenced this pull request Feb 12, 2019
@zz-jason
expression: handle ENUM in builtin function Values() (pingcap#9225)
9191bad
@zz-jason zz-jason mentioned this pull request Feb 12, 2019
Merged
zz-jason added a commit that referenced this pull request Feb 12, 2019
@zz-jason
expression: handle ENUM in builtin function Values() (#9225) (#9280)
58dacb6
zz-jason added a commit that referenced this pull request Feb 13, 2019
@zz-jason
expression: handle ENUM in builtin function Values() (#9225) (#9281)
1e962c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eurekaka eurekaka eurekaka left review comments

@alivxxx alivxxx alivxxx approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees
No one assigned
Labels
component/expression status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enum + insert on duplicate update > data truncate
4 participants
@zz-jason @codecov-io @eurekaka @alivxxx